Apply fallback content to frontpage. #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hofmannsven
changed the title
hofmannsven
changed the title
hofmannsven
changed the title
alpipego
requested changes
Jun 25, 2018
There was a problem hiding this comment.
Instead of the generic, utility classes .card and .info, I prefer to have semantic namespaced classes/CSS.
If (and better when) the declarations of .card will be reused. It should be declared as a mixin.
Until then I prefer to have the declaration in the element it applies to.
| @@ -28,11 +28,30 @@ | |||
| ); | |||
| $provider = new CachedProvider($provider); | |||
|
|
|||
| // Display `the_content` only if there are no valid events. | |||
| add_filter('wpberlin/website/front_page_no_events', function ($title, $content) use ($provider) { | |||
There was a problem hiding this comment.
I think this filter (as well as the one below), should be put into the theme instead of the plugin. Instead of coupling the theme to the plugin, we should add the plugin as a dependency to the theme (cf. #41)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new filter (
wpberlin/website/front_page_no_events) that gets applied in the templatefront-page.phpso that the title and the content from this page are displayed if there are no valid events. The content for this page can be found incontent/home.md.Furthermore I renamed the action hook
wpberlin/website/front_pagetowpberlin/website/front_page_eventsand added a new SCSS element (elements/card).